Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#103 path params feature #117

Merged
merged 2 commits into from
Jan 24, 2018
Merged

#103 path params feature #117

merged 2 commits into from
Jan 24, 2018

Conversation

jeevatkm
Copy link
Member

@jeevatkm jeevatkm commented Jan 23, 2018

Implementation of #103

@jeevatkm jeevatkm added this to the v1.1 Milestone milestone Jan 23, 2018
@jeevatkm jeevatkm self-assigned this Jan 23, 2018
@codecov
Copy link

codecov bot commented Jan 23, 2018

Codecov Report

Merging #117 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #117      +/-   ##
==========================================
+ Coverage    96.6%   96.69%   +0.08%     
==========================================
  Files          10       10              
  Lines        1002     1028      +26     
==========================================
+ Hits          968      994      +26     
  Misses         19       19              
  Partials       15       15
Impacted Files Coverage Δ
request17.go 100% <ø> (ø) ⬆️
request16.go 100% <ø> (ø) ⬆️
request.go 100% <100%> (ø) ⬆️
middleware.go 92.09% <100%> (-0.04%) ⬇️
default.go 100% <100%> (ø) ⬆️
client.go 97.7% <100%> (+0.04%) ⬆️
util.go 92.92% <100%> (+1.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc8cd45...63b75bd. Read the comment docs.

@jeevatkm jeevatkm merged commit ad03978 into master Jan 24, 2018
@jeevatkm jeevatkm deleted the path-params branch February 4, 2018 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant