Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved override header handling #125

Merged
merged 1 commit into from
Feb 7, 2018
Merged

improved override header handling #125

merged 1 commit into from
Feb 7, 2018

Conversation

jeevatkm
Copy link
Member

@jeevatkm jeevatkm commented Feb 6, 2018

Supersedes PR #121

@jeevatkm jeevatkm added this to the v1.3 Milestone milestone Feb 6, 2018
@jeevatkm jeevatkm self-assigned this Feb 6, 2018
@codecov
Copy link

codecov bot commented Feb 6, 2018

Codecov Report

Merging #125 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #125      +/-   ##
==========================================
+ Coverage   96.33%   96.33%   +<.01%     
==========================================
  Files          10       10              
  Lines        1037     1038       +1     
==========================================
+ Hits          999     1000       +1     
  Misses         21       21              
  Partials       17       17
Impacted Files Coverage Δ
middleware.go 92.23% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d106797...f185355. Read the comment docs.

@jeevatkm jeevatkm merged commit 09f1952 into master Feb 7, 2018
@jeevatkm jeevatkm deleted the headers-override branch March 7, 2018 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant