Add support for bazel build rules #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a basic workspace and bazel rules. The rules were generated via gazelle (blaze run :gazelle) and tuned a bit (e.g. changing visibility and adding the data dependency). This should allow bazel users to just depend on the project without a local BUILD file.
Codecov Report
@@ Coverage Diff @@
## master #141 +/- ##
=======================================
Coverage 96.05% 96.05%
=======================================
Files 9 9
Lines 1065 1065
=======================================
Hits 1023 1023
Misses 23 23
Partials 19 19Continue to review full report at Codecov.
|
jeevatkm
requested changes
Apr 11, 2018
There was a problem hiding this comment.
@paradoxengine Could you please add details of build file on README.md?
Mention bazel support in the readme file. Once this is committed, if useful, I can add a sample load statement and build config to depend on resty (I want to be sure it's tested first)
|
Sure, I've added some simple text, let me know if that's enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a basic workspace and bazel rules.
The rules were generated via gazelle (blaze run :gazelle) and tuned a bit (e.g. changing visibility and adding the data dependency).
This should allow bazel users to just depend on the project without a local BUILD file.