Option to close connection for each HTTP request

[aanm]

Signed-off-by: André Martins [email protected]

[jeevatkm]

@aanm Thanks for the PR.

Technically there is no leak as per golang core. Below note taken from golang godoc-

// For client requests, setting this field prevents re-use of
// TCP connections between requests to the same hosts, as if
// Transport.DisableKeepAlives were set.
Close bool

So there is no issue with go-resty library. I will be renaming the PR subject.

---

I would say it up to developer or user choose the behavior they need. My recommendation is to expose some sort setter method to opt-in if they want to close connection for each request and defaults to false (also same as golang core).

your thoughts?

[aanm]

@jeevatkm True, on my use case all connection were for the same host but with multiple resty clients. Setting that option to true dropped the number of connections open by 70%. I'll think on something an make it as an option. Any ideas where it would be the best place to put it?

[jeevatkm]

You have specific use case. No issues. Best place is to -

• Create a field called closeConnection after mutex field
• Add SetCloseConnection for client struct like
  • func (c *Client) SetCloseConnection(close bool) *Client
  • Please add nice godoc documentation, so user can understand the purpose
• Initialize explicitly on client creation after mutex field like closeConnection: false
• Also please add SetCloseConnection method to default.go like you did in previous PR

finally assign in it the request (you already pick spot for this PR, but small change):

r.RawRequest.Close = c.closeConnection

[jeevatkm]

Test case please and watch out travis ci build.

[codecov-io]

Current coverage is 96.99%

Merging #31 into master will increase coverage by 0.02%

@@             master        #31   diff @@
==========================================
  Files             5          5          
  Lines           759        766     +7   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            736        743     +7   
  Misses           13         13          
  Partials         10         10          

Powered by Codecov. Last updated by 73f3362...84d1c0e

[aanm]

@jeevatkm ping