-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conditional retry #37
Conversation
Squashed commits: [1e0d00b] Removed reference. (+1 squashed commit) Squashed commits: [ddbe095] Added backoff retry mechanism.
Current coverage is 96.84% (diff: 98.27%)
|
Depends on #35. |
This is nice. I have went through the changes, it seems you have taken implementation from #35 and then added conditional retry ability. I have suggestion here. Can you please hold on for merging #35 (will do as soon as a get a time) and then branch out & add yours? In this way both contributors changes will come to resty separately. I would like to appreciate both contribution. |
@dmiller113 I have merged #35 to master. Please branch out master and add your conditional retry. I appreciate your efforts. I'm closing this one. |
@dmiller113 awaiting your PR, Thanks. |
@dmiller113 I hope you don't mind, if incorporate your contribution into resty and release your contribution. |
Added the ability to add conditions in which to actually retry instead of only on returned errors from the response. This allows you to retry you request again in the case of bad responses in addition to retrying based upon response status codes.