add SetCookieJar method #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lrita
commented
Apr 28, 2017
lrita
commented
- allow user override default CookieJar in resty client
Codecov Report
@@ Coverage Diff @@
## master #69 +/- ##
=========================================
+ Coverage 96.78% 96.8% +0.01%
=========================================
Files 11 11
Lines 902 907 +5
=========================================
+ Hits 873 878 +5
Misses 15 15
Partials 14 14
Continue to review full report at Codecov.
|
* allow user override default CookieJar in resty client
jeevatkm
reviewed
Apr 29, 2017
default.go
Outdated
| @@ -89,6 +89,11 @@ func SetHeaders(headers map[string]string) *Client { | |||
| return DefaultClient.SetHeaders(headers) | |||
| } | |||
|
|
|||
| // SetCookieJa sets custom http.CookieJar. See `Client.SetCookieJar` for more information. | |||
There was a problem hiding this comment.
Just one typo error in godoc SetCookieJa => SetCookieJar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.