WIP: Allow setting any http.RoundTripper as transport
#74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of limiting users to `*http.Transport` only.
Codecov Report
@@ Coverage Diff @@
## master #74 +/- ##
==========================================
- Coverage 96.65% 94.67% -1.98%
==========================================
Files 9 9
Lines 926 939 +13
==========================================
- Hits 895 889 -6
- Misses 16 28 +12
- Partials 15 22 +7
Continue to review full report at Codecov.
|
|
@bak1an Thank you for the updates. |
|
@bak1an Hope you're doing well. Any updates on this feature? |
|
@jeevatkm Not yet, will try to wrap it up this weekend. Thanks! |
|
@bak1an Thanks, please let me know, if you need a hand. |
Closed
jeevatkm
changed the title
http.RoundTripper as transporthttp.RoundTripper as transport [jeevatkm: final touch]
jeevatkm
changed the title
http.RoundTripper as transport [jeevatkm: final touch]http.RoundTripper as transport
|
Closing this PR in-favor of #91 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proper doc and test coverage is in progress...