feat(enhancement): remove unnecessary map for raw path params instead use path params #924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jeevatkm
commented
Dec 2, 2024
jeevatkm
commented
- correct digest roundtrip return value on error scenario
- streamline content-length value on buffer and partial io.Reader flow
- correct typo of ContentDecompressor -> ContentDecompressor
- refactor createHTTPRequest -> createRawRequest
- update c.log -> c.Logger()
- update redundant err check and if conditions
- address curl cmd non-execute request error flow
- prevent reset buffer during buffer copy on request clone
- improve test cases and corner coverage
- move benchmarks into a dedicated file
- update godoc
… use path params - correct digest roundtrip return value on error scenario - streamline content-length value on buffer and partial io.Reader flow - correct typo of ContentDecompressor -> ContentDecompressor - refactor createHTTPRequest -> createRawRequest - update c.log -> c.Logger() - update redundant err check and if conditions - address curl cmd non-execute request error flow - prevent reset buffer during buffer copy on request clone - improve test cases and corner coverage - move benchmarks into a dedicated file - update godoc
- update test cmd with gotestsum executable to display test name - apply mod tidy
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v3 #924 +/- ##
=====================================
Coverage ? 99.91%
=====================================
Files ? 15
Lines ? 3340
Branches ? 0
=====================================
Hits ? 3337
Misses ? 2
Partials ? 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.