Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow authentication using cookies #748

Closed
wants to merge 4 commits into from
Closed

Conversation

fmartingr
Copy link
Member

Allow the AuthenticationMiddleware to read the JWT token from cookies so we can load static pages outside the API (like the bookmark archive and ebook) safely.

@fmartingr fmartingr self-assigned this Oct 10, 2023
Copy link
Collaborator

@Monirzadeh Monirzadeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything work fine just i think we should add token to the cookies in login and remove that on logout

@fmartingr
Copy link
Member Author

Included in #742

@fmartingr fmartingr closed this Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants