refactor: migrate bookmark static pages to new http server

[fmartingr]

• Migrate /bookmark/:id/content to new http server
• Migrate /bookmark/:id/thumb to new http server
• Migrate /bookmark/:id/archive to new http server
  • Refactor archive bookmark template to be a static file with an iframe to the actual archive rather than modifying the archive HTML to include arbitrary HTML
• Rename symbol model.Bookmark into model.BookmarkDTO to prepare future changes
• Create BookmarkDomain to perform operations with Bookmarks
  • HasEbook
  • HasArchive
  • GetThumbnailPath
  • HasThumbnail
  • GetBookmark
  • GetBookmarkContentsFromArchive
• ArchiverDomain
  • GetBookmarkArchive
• StorageDomain
• Domain unit testing
• Database mock
• Use afero as filesystem abstraction

Fixes #751

[codecov]

Codecov Report

Attention: 120 lines in your changes are missing coverage. Please review.

Comparison is base (fe6a306) 22.06% compared to head (15c19df) 24.99%.

Files	Patch %	Lines
internal/http/routes/bookmark.go	72.80%	22 Missing and 9 partials ⚠️
internal/domains/storage.go	66.03%	12 Missing and 6 partials ⚠️
internal/domains/archiver.go	0.00%	11 Missing ⚠️
internal/http/routes/api/v1/bookmarks.go	0.00%	10 Missing ⚠️
internal/domains/accounts.go	0.00%	7 Missing ⚠️
internal/cmd/root.go	0.00%	6 Missing ⚠️
internal/domains/bookmarks.go	76.00%	4 Missing and 2 partials ⚠️
internal/webserver/handler-api.go	0.00%	6 Missing ⚠️
internal/cmd/server.go	0.00%	5 Missing ⚠️
internal/http/routes/legacy.go	0.00%	5 Missing ⚠️
... and 9 more

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #775      +/-   ##
==========================================
+ Coverage   22.06%   24.99%   +2.92%     
==========================================
  Files          42       45       +3     
  Lines        5696     5534     -162     
==========================================
+ Hits         1257     1383     +126     
+ Misses       4262     3959     -303     
- Partials      177      192      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[fmartingr]

Hey @Monirzadeh, can you take a quick peek at this? Sorry that it's gotten really big, but I had to refactor several things to properly solve the main issue. Let me know if the general direction and changes seems ok and are properly understood. Thanks!

[Monirzadeh]

WOW, this is great!
You solve a lot of things.
I left some comments and questions, I don't see any major problems. beside them we just need more unit test to cover all new functions.

I see some TODO that we can solve them later, just point one of them to solve before merge or create an issue to not forget that.
Thanks for your time spend on the project. ❤️

[Monirzadeh]

everything is fine to me.
just currently we can't remove os and create tmp file in vfs in this part right?
if it possible remove os from processing.go too

err = warc.NewArchive(archivalRequest, tmpFile.Name())
		if err != nil {
			defer os.Remove(tmpFile.Name())
			return book, false, fmt.Errorf("failed to create archive: %v", err)
		}

[fmartingr]

everything is fine to me.

just currently we can't remove os and create tmp file in vfs in this part right?

if it possible remove os from processing.go too

err = warc.NewArchive(archivalRequest, tmpFile.Name())

		if err != nil {

			defer os.Remove(tmpFile.Name())

			return book, false, fmt.Errorf("failed to create archive: %v", err)

		}

For the external libraries that dont support it we may need to download/upload the files after working with them in a temporary file locally. As long as the files used locally are ephemeral (not used for long term storage, only temporary) we are fine. But since right now we only allow local filesystem everything should keep working as it was.