fix: regressions and documentation from 1.5.5 upgrade

[fmartingr]

• Add required flags for the serve command to behave properly after upgrading to 1.6.0.
• Updated initial account references in the docs, since now it's a real account it wont be removed automatically.
• Removed shiori serve references from the docs.
• Removed commented out migrated routes from the legacy http router
• Upgraded go dependencies
  • Left go-epub at 1.2.0 due to a filename error on windows: automatic file naming should clean filenames properly go-epub#26

[fmartingr]

Hey @Monirzadeh take a look at this, anything I missed and should take a look at before releasing 1.6.0? I did a 1.5.5 to 1.6.0 upgrade locally and everything seem working as usual.

[codecov]

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (09bc9b4) 25.49% compared to head (769fdfc) 25.58%.

Files	Patch %	Lines
internal/cmd/serve.go	0.00%	1 Missing ⚠️
internal/config/config.go	83.33%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #837      +/-   ##
==========================================
+ Coverage   25.49%   25.58%   +0.08%     
==========================================
  Files          47       47              
  Lines        5632     5628       -4     
==========================================
+ Hits         1436     1440       +4     
+ Misses       3997     3989       -8     
  Partials      199      199              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Monirzadeh]

Hi it fine to me maybe some small changes
maybe better remove line bellow as you remove General in bullet list

shiori/docs/Frequently-Asked-Question.md

Line 23 in 09bc9b4

# General

maybe we can server command there instead of serve in this two line too

shiori/docs/Frequently-Asked-Question.md

Line 154 in 09bc9b4

ExecStart=/home/user/go/bin/shiori serve --portable

shiori/docs/Frequently-Asked-Question.md

Line 171 in 09bc9b4

ExecStart=/usr/bin/shiori serve

and in other files too like

shiori/docs/Installation.md

Line 93 in 09bc9b4

command: ["/usr/bin/shiori", "serve", "--webroot", "/shiori"]

can we warning user with something like bellow line if user use serve command?
serve command will deprecation in future please use server instead

this part change too in new version maybe better to update that with new output (for example serve not exist any more in output of -h)

shiori/docs/Usage.md

Lines 52 to 76 in 09bc9b4

	Simple command-line bookmark manager built with Go
	Usage:
	shiori [command]
	Available Commands:
	add Bookmark the specified URL
	check Find bookmarked sites that no longer exists on the internet
	delete Delete the saved bookmarks
	export Export bookmarks into HTML file in Netscape Bookmark format
	help Help about any command
	import Import bookmarks from HTML file in Netscape Bookmark format
	open Open the saved bookmarks
	pocket Import bookmarks from Pocket's exported HTML file
	print Print the saved bookmarks
	serve Serve web interface for managing bookmarks
	server Run the Shiori webserver [alpha]
	update Update the saved bookmarks
	version Output the shiori version
	Flags:
	-h, --help help for shiori
	--portable run shiori in portable mode
	Use "shiori [command] --help" for more information about a command.

could we remove those legacy path that still remain in code? if i am not wrong we remove function related to them too (maybe in other PR to keep things organize)

shiori/internal/http/routes/legacy.go

Lines 83 to 89 in 09bc9b4

	// router.GET(jp("/bookmark/:id/thumb"), withLogging(hdl.serveThumbnailImage))
	// legacyGroup.GET("/bookmark/:id/thumb", r.handle(r.legacyHandler.ServeThumbnailImage))
	// router.GET(jp("/bookmark/:id/content"), withLogging(hdl.serveBookmarkContent))
	// legacyGroup.GET("/bookmark/:id/content", r.handle(r.legacyHandler.ServeBookmarkContent))
	// router.GET(jp("/bookmark/:id/archive/*filepath"), withLogging(hdl.serveBookmarkArchive))
	// legacyGroup.GET("/legacy/:id/archive/", r.handle(r.legacyHandler.ServeBookmarkArchive))
	// legacyGroup.GET("/legacy/:id/archive/*filepath", r.handle(r.legacyHandler.ServeBookmarkArchive))

something like #836 should be present in Release candidate first? so we can't have that in 1.6.0 right?
can you please update go-epub to the last release 1.2.1 before release? we fix some bugs in toc etc.
Thanks for your hard work on the project ❤️

[fmartingr]

@Monirzadeh Thanks for the suggestions. Answering to your comments:

• The shiori serve still works, but shows as deprecated when run and is only a proxy of the shiori server command. We will remove it at a later date.
• I will update all references to shiori serve from the docs. Good catch.
• I will remove the commented out old api endpoints
• I will update the go-epub dependency (and any other outdated dependencies)
• feat: allow authentication using proxy request header #836 won't be ready for 1.6.0 and I don't want to put anything else for the release, it has enough content as is.

[Monirzadeh]

Beside you forget to remove # General line (That don't have that in toc) things ok to me 👍

[fmartingr]

Beside you forget to remove # General line (That don't have that in toc) things ok to me 👍

Oh sorry, I forgot about that. Fixed the headings d679c84