Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use thumbnail as ebook cover #943

Merged
merged 3 commits into from
Jun 26, 2024

Conversation

Monirzadeh
Copy link
Collaborator

this PR try to test different solution for eBook cover.

  • first solution is use thumbnail as cover simple and fast but aspect ration is not the best

Copy link
Member

@fmartingr fmartingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good first step. 👍

@fmartingr fmartingr merged commit a3d4a68 into go-shiori:master Jun 26, 2024
9 checks passed
@Monirzadeh Monirzadeh deleted the cover-ebook branch June 26, 2024 17:18
@Monirzadeh Monirzadeh self-assigned this Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants