Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong eventBus.js path and non-existant method call #971

Merged
merged 4 commits into from
Aug 28, 2024

Conversation

fmartingr
Copy link
Member

  • Fixes the path to the eventBus.js file on the index.html file
  • Fixes the login page calling to an undefined loadSetting method

Closes #962

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.17%. Comparing base (9a113af) to head (02d47cc).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #971   +/-   ##
=======================================
  Coverage   35.17%   35.17%           
=======================================
  Files          61       61           
  Lines        4065     4065           
=======================================
  Hits         1430     1430           
  Misses       2413     2413           
  Partials      222      222           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Monirzadeh Monirzadeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@fmartingr fmartingr merged commit a4304bc into master Aug 28, 2024
14 checks passed
@fmartingr fmartingr deleted the fix/eventbus-path branch August 28, 2024 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong application path for asset/eventBus.js
2 participants