introduce runTestsParallel #1489
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d3ed0b2.
dolmen
suggested changes
Oct 18, 2023
| t.Run("default", func(t *testing.T) { | ||
| dbt := &DBTest{t, db} | ||
| t.Cleanup(func() { | ||
| dbt.db.Exec("DROP TABLE IF EXISTS test") | ||
| }) | ||
| test(dbt) | ||
| dbt.db.Exec("DROP TABLE IF EXISTS test") |
There was a problem hiding this comment.
This is now redundant with the Cleanup.
| if _, err := rand.Read(buf[:]); err != nil { | ||
| t.Fatal(err) | ||
| } | ||
| tableName := fmt.Sprintf("test_%x", buf[:]) |
There was a problem hiding this comment.
There is a non-zero risk of having two tests started with the same table name.
It would be better to use the index of the iteration of the for loop and a hash of the test name from which runTestsParallel is called.
| db.Exec("DROP TABLE IF EXISTS " + tableName) | ||
| dbt := &DBTest{t, db} | ||
| test(dbt, tableName) | ||
| dbt.db.Exec("DROP TABLE IF EXISTS test") |
There was a problem hiding this comment.
Remaining reference to table test.
| db.Exec("DROP TABLE IF EXISTS " + tableName) | ||
| dbt := &DBTest{t, db} | ||
| test(dbt, tableName) | ||
| dbt.db.Exec("DROP TABLE IF EXISTS test") |
There was a problem hiding this comment.
Remaining reference to table test.
|
The two functions below could be useful to abstract the handling of the DB connection life cycle in a test: func openDB(tb testing.TB, dsn string) *sql.DB {
tb.Helper()
db, err := sql.Open("mysql", dsn)
if err != nil {
tb.Fatalf("open %q: %v", path, err)
}
tb.Cleanup(func() {
err := db.Close()
if err != nil {
tb.Error("close DB:", err)
}
})
return db
}
func openDBTest(t *testing.T, dsn string) *DBTest {
tb.Helper()
db := openDB(dsn)
return &DBTest{t, db}
}They could be used in both |
|
Could not speed up as much as I expected. Close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please explain the changes you made here.
Checklist