test: remove private api usages in tests #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slsyy
force-pushed
the
remove-private-api-usages-in-tests
branch
3 times, most recently
from
2c64df0
to
8715753
Compare
slsyy
force-pushed
the
remove-private-api-usages-in-tests
branch
from
8715753
to
bed11a0
Compare
refactor tests, so private interfaces are not used: * split batches in tests * remove batchSplitter interface, which is not used after refactor * replace quoteKeyword with simple substitution. it is not needed as table names in tests are not problematic I need this for a lib/tests module split
slsyy
force-pushed
the
remove-private-api-usages-in-tests
branch
from
bed11a0
to
278f8ad
Compare
andreynering
approved these changes
Oct 19, 2024
slsyy
added a commit
that referenced
this pull request
Oct 29, 2024
one place, which I omitted in #221
slsyy
added a commit
that referenced
this pull request
Oct 29, 2024
one place, which I omitted in #221
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor tests, so private interfaces are not used:
table names in tests are not problematic
I need this for a lib/tests module split