Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add patchLevel -p2 for drupal/core. #359

Merged
merged 1 commit into from
Dec 15, 2020
Merged

Add patchLevel -p2 for drupal/core. #359

merged 1 commit into from
Dec 15, 2020

Conversation

robincee
Copy link
Contributor

Problem
Patches in core are not correctly applied.
Solution
Add patchLevel -p2 to drupal/core in composer.json.

@bramtenhove
Copy link
Member

Do we need to add this in all other root composer.json files as well?

Copy link
Collaborator

@ronaldtebrake ronaldtebrake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ronaldtebrake
Copy link
Collaborator

Do we need to add this in all other root composer.json files as well?

At least every top level composer.json (e.g. social template / drupal social)

cweagans/composer-patches#189 allows us to specify it now, and for more info
https://www.previousnext.com.au/blog/patch-drupal-core-without-things-ending-up-corecore-or-coreb

it tries to cycle through the patch level (1, 0, 2, 4) when nothing is specified

So I believe we can leave it out of Open Social itself, so users can specify the patch level differently if necessary when using open_social as dependency without our top level usages.

Same as the entry point for core
https://github.com/drupal-composer/drupal-project/blob/9.x/composer.json#L76

@robincee
Copy link
Contributor Author

At least every top level composer.json (e.g. social template / drupal social)

  • / mv - yes agreed.

So I believe we can leave it out of Open Social itself,

As long as social can't be installed without drupal_social / social_template it has no use indeed.

@robincee robincee merged commit c1478af into master Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants