Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: fix permissions for admin device listing #12787

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Jan 23, 2025

Details

Previously we required view permissions for all device types to access this endpoint. This PR changes the behaviour to filter based on the accessible devices by view permission


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@BeryJu BeryJu requested a review from a team as a code owner January 23, 2025 17:56
@BeryJu
Copy link
Member Author

BeryJu commented Jan 23, 2025

/cherry-pick version-2024.12

Copy link

netlify bot commented Jan 23, 2025

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 7cb4139
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/679282dc97f79c0008430eaa

Copy link

netlify bot commented Jan 23, 2025

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit 7cb4139
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/679282dcfa09700008298317

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.76%. Comparing base (02bdf09) to head (7cb4139).
Report is 4 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12787      +/-   ##
==========================================
+ Coverage   92.70%   92.76%   +0.06%     
==========================================
  Files         769      769              
  Lines       38912    38911       -1     
==========================================
+ Hits        36072    36097      +25     
+ Misses       2840     2814      -26     
Flag Coverage Δ
e2e 48.57% <50.00%> (+0.09%) ⬆️
integration 24.62% <0.00%> (+<0.01%) ⬆️
unit 90.40% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-7cb41391e9152bd7e7a95318d05dfa278418635a
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-7cb41391e9152bd7e7a95318d05dfa278418635a

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu merged commit 7d8094d into main Jan 24, 2025
73 checks passed
@BeryJu BeryJu deleted the core/fix-admin-device-list-perms branch January 24, 2025 02:25
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jan 24, 2025
BeryJu added a commit that referenced this pull request Jan 24, 2025
…12791)

core: fix permissions for admin device listing (#12787)

Signed-off-by: Jens Langhammer <[email protected]>
Co-authored-by: Jens L. <[email protected]>
kensternberg-authentik added a commit that referenced this pull request Jan 27, 2025
* main: (26 commits)
  website: bump docusaurus-plugin-openapi-docs from 4.3.1 to 4.3.2 in /website (#12844)
  core: bump aws-cdk-lib from 2.176.0 to 2.177.0 (#12842)
  lifecycle/aws: bump aws-cdk from 2.176.0 to 2.177.0 in /lifecycle/aws (#12845)
  web: Fix issue where Codemirror partially applies OneDark theme. (#12811)
  ci: fix container build always attempting to push (#12810)
  lifecycle: better pre release test (#12806)
  rbac: exclude permissions for internal models (#12803)
  web: bump store2 from 2.14.3 to 2.14.4 in /web (#12805)
  website: integrations-all: update doc titles to start with "integrate with" (#12775)
  web/flows: fix `login` / `log in` inconsistency (#12526)
  flows: clear flow state before redirecting to final URL (#12788)
  core: bump goauthentik.io/api/v3 from 3.2024122.2 to 3.2024122.3 (#12793)
  core: bump kubernetes from 31.0.0 to 32.0.0 (#12794)
  core: bump pydantic from 2.10.5 to 2.10.6 (#12795)
  core: bump msgraph-sdk from 1.17.0 to 1.18.0 (#12796)
  core: bump selenium from 4.28.0 to 4.28.1 (#12797)
  core: bump ruff from 0.9.2 to 0.9.3 (#12798)
  website/integrations: Add troubleshooting part to Synology guide (#12681)
  core: fix permissions for admin device listing (#12787)
  website/docs: Flesh out Google Workspaces SAML. (#12701)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants