Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web/admin: rework captcha stage #9256

Merged
merged 2 commits into from
Apr 15, 2024
Merged

web/admin: rework captcha stage #9256

merged 2 commits into from
Apr 15, 2024

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Apr 14, 2024

Details

closes #9045


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Jens Langhammer <[email protected]>
@BeryJu BeryJu requested review from a team as code owners April 14, 2024 19:13
Copy link

netlify bot commented Apr 14, 2024

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 746ca70
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/661cfaae51c7690007bd9e9f

Copy link

netlify bot commented Apr 14, 2024

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit 746ca70
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/661cfaaeffae3500087a3734

Copy link

codecov bot commented Apr 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.42%. Comparing base (8f2b7f2) to head (746ca70).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9256      +/-   ##
==========================================
+ Coverage   92.40%   92.42%   +0.01%     
==========================================
  Files         647      647              
  Lines       32005    32011       +6     
==========================================
+ Hits        29575    29585      +10     
+ Misses       2430     2426       -4     
Flag Coverage Δ
e2e 50.40% <ø> (+0.03%) ⬆️
integration 26.35% <ø> (+<0.01%) ⬆️
unit 89.82% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeryJu BeryJu requested a review from a team as a code owner April 15, 2024 10:00
Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-746ca70ef78f4d5edb2393de501b2d9e168b72e2
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-746ca70ef78f4d5edb2393de501b2d9e168b72e2-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-ghcr.io/goauthentik/dev-server:gh-746ca70ef78f4d5edb2393de501b2d9e168b72e2

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-ghcr.io/goauthentik/dev-server:gh-746ca70ef78f4d5edb2393de501b2d9e168b72e2-arm64

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu merged commit bc9984f into main Apr 15, 2024
65 checks passed
@BeryJu BeryJu deleted the web/flow/rework-captcha-stage branch April 15, 2024 10:38
@franciscomfcmaia
Copy link

In Release 2024.4 this seems to still be an issue. Is there any action required from our side to apply this fix?

Screenshot 2024-05-09 at 21 50 45

@BeryJu
Copy link
Member Author

BeryJu commented May 9, 2024

See https://docs.goauthentik.io/docs/flow/stages/captcha/#turnstile, you'll have to set it to invisible mode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom Captcha is at the bottom of the page
2 participants