Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relational MM: Cluster LMust #1643

Merged
merged 7 commits into from
Jan 14, 2025
Merged

Relational MM: Cluster LMust #1643

merged 7 commits into from
Jan 14, 2025

Conversation

michael-schwarz
Copy link
Member

Re-creates #1555 but targeting master this time.

Currently, LMust is unclustered even when clusters are employed. This leads to precision loss compared to the unclustered variant when:

  • Values are published to a mutex a for some clusters only
  • a is added to LMust
  • Upon lock(a), V.mutex_inits is not consulted for any cluster, as a is in LMust

However, V.mutex_inits should still be consulted for clusters that have not been published yet.

This also clusters LMust and adds a regression test for this behavior.

c.f. #1551

@michael-schwarz michael-schwarz added precision relational Relational analyses (Apron, affeq, lin2var) labels Dec 17, 2024
@sim642 sim642 self-requested a review December 18, 2024 12:02
@sim642
Copy link
Member

sim642 commented Jan 6, 2025

However, V.mutex_inits should still be consulted for clusters that have not been published yet.

This PR is marked as a precision improvement, but why isn't this a soundness matter?

src/analyses/apron/relationPriv.apron.ml Outdated Show resolved Hide resolved
src/analyses/apron/relationPriv.apron.ml Outdated Show resolved Hide resolved
src/analyses/commonPriv.ml Outdated Show resolved Hide resolved
@michael-schwarz
Copy link
Member Author

This PR is marked as a precision improvement, but why isn't this a soundness matter?

It in fact is. I added another regression test for which master currently is unsound.

@sim642 sim642 added this to the v2.6.0 milestone Jan 14, 2025
@michael-schwarz michael-schwarz merged commit db4413b into master Jan 14, 2025
21 checks passed
@michael-schwarz michael-schwarz deleted the lmust_cluster branch January 14, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug precision relational Relational analyses (Apron, affeq, lin2var) unsound
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants