changed behavior for missing user, in the SetCurrentUser
middleware
#92
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is being done in this PR?
In the scaffolded
actions/users.go
, middlewareSetCurrentUser
just returned a general error which causes a404
error. However, it could be better if the middleware generatesUnauthorized
or just redirects users to the login page. With this change, the middleware redirects the user to the login page.fixes #30
see also: #30 (comment)
What are the main choices made to get to this solution?
List the manual test cases you've covered before sending this PR: