fixed the bug in the extra args handling #93
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is being done in this PR?
Currently, the type of all extra columns is set as
string
which is the default and thenull
handling is not working. With this fix,nulls.Type
supported by modulenulls
, the migration will allow the null value.Now the generated files are something like
for the same command used in #21,
buffalo g auth age:int bio:nulls.Text
.fixes #21
What are the main choices made to get to this solution?
Actually, there could be better options such as integration with fizz, and improving the function and the logic used for extra arguments handling, but I just simply fixed the bug with a smaller modification while keeping the current implementation as is today.
List the manual test cases you've covered before sending this PR:
Manual test with a simple todo app.