Merge pull request #816 from gobuffalo/set-docker-addr

set the default binding address of generated Dockerfiles
gobuffalo · Dec 20, 2017 · 4a35c4c · 4a35c4c
2 parents 39db630 + d13b4f2
commit 4a35c4c
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/generators/docker/multi/templates/Dockerfile.tmpl b/generators/docker/multi/templates/Dockerfile.tmpl
@@ -28,13 +28,16 @@ FROM alpine
 RUN apk add --no-cache bash
 RUN apk add --no-cache ca-certificates
 
-# Comment out to run the binary in "production" mode:
-# ENV GO_ENV=production
-
 WORKDIR /bin/
 
 COPY --from=builder /bin/app .
 
+# Comment out to run the binary in "production" mode:
+# ENV GO_ENV=production
+
+# Bind the app to 0.0.0.0 so it can be seen from outside the container
+ENV ADDR=0.0.0.0
+
 EXPOSE 3000
 
 # Comment out to run the migrations before running the binary:

diff --git a/generators/docker/standard/templates/Dockerfile.tmpl b/generators/docker/standard/templates/Dockerfile.tmpl
@@ -24,6 +24,12 @@ RUN go get $(go list ./... | grep -v /vendor/)
 {{end -}}
 RUN buffalo build --static -o /bin/app
 
+# Comment out to run the binary in "production" mode:
+# ENV GO_ENV=production
+
+# Bind the app to 0.0.0.0 so it can be seen from outside the container
+ENV ADDR=0.0.0.0
+
 EXPOSE 3000
 
 # Comment out to run the migrations before running the binary: