Using safe for simple worker (#1628)

runtime/version.go

@@ -1,4 +1,4 @@
 package runtime
 
 // Version is the current version of the buffalo binary
-const Version = "v0.14.1"
+const Version = "v0.14.2"

worker/simple.go

@@ -5,6 +5,7 @@ import (
 	"sync"
 	"time"
 
+	"github.com/markbates/safe"
 	"github.com/pkg/errors"
 	"github.com/sirupsen/logrus"
 )
@@ -82,7 +83,10 @@ func (w Simple) Perform(job Job) error {
 	defer w.moot.Unlock()
 	if h, ok := w.handlers[job.Handler]; ok {
 		go func() {
-			err := h(job.Args)
+			err := safe.RunE(func() error {
+				return h(job.Args)
+			})
+
 			if err != nil {
 				w.Logger.Error(err)
 			}

worker/simple_test.go

@@ -46,6 +46,31 @@ func Test_Simple_PerformAt(t *testing.T) {
 	r.True(hit)
 }
 
+func Test_Simple_PerformBroken(t *testing.T) {
+	r := require.New(t)
+
+	var hit bool
+	wg := &sync.WaitGroup{}
+	wg.Add(1)
+
+	w := NewSimple()
+	w.Register("x", func(Args) error {
+		hit = true
+		wg.Done()
+
+		//Index out of bounds on purpose
+		println([]string{}[0])
+
+		return nil
+	})
+
+	w.Perform(Job{
+		Handler: "x",
+	})
+	wg.Wait()
+	r.True(hit)
+}
+
 func Test_Simple_PerformIn(t *testing.T) {
 	r := require.New(t)