[Bug] "Generate resource" command with "--skip-model" flag results in faulty resource

[PeterdeJ]

Description

Just started using Buffalo, trying out all the beautiful features :)

I'm having an issue however with the "generate resource" command in combination with the "--skip-model" flag. When this flag is used, all the generated functions ("List", "Show", "Create", "Update" and "Destroy") are created fully in lowercase. The struct however that is also generated refers to "buffalo.Resource" and contains these functions with the first letter in uppercase, resulting in a resource that doesn't work.

Steps to Reproduce the Problem

1. Use generate resource command with "--skip-model" flag: buffalo g r todo --skip-model.
2. Run the application using: buffalo dev.
3. Navigate to "http://127.0.0.1:3000/todoes"; verify that you get an error saying "runtime error: invalid memory address or nil pointer dereference".
4. Verify in the generated file that "todoes.go" contains the generated functions ("List", "Show", "Create", "Update" and "Destroy") fully in lowercase, while the generated struct called "TodoesResource" refers to "buffalo.Resource" and contains these functions with the first letter in uppercase.

Expected Behavior

I expected the generated functions to have the first letter in uppercase, matching the names in "buffalo.Resource" and resulting in the response "Todo#list" when navigating to "http://127.0.0.1:3000/todoes" (after starting the application). This is the case when you don't use the "--skip-model" flag, so I'm not sure why this would behave differently when you do use this flag.

Actual Behavior

The generated functions ("List", "Show", "Create", "Update" and "Destroy") are fully in lowercase, while the generated struct called "TodoesResource" refers to "buffalo.Resource" and contains these functions with the first letter in uppercase. This results in the error "runtime error: invalid memory address or nil pointer dereference" when navigating to "http://127.0.0.1:3000/todoes" (after starting the application).

Info

-> Go: Checking installation
✓ The go executable was found on your system at: /usr/local/go/bin/go

-> Go: Checking minimum version requirements
✓ Your version of Go, 1.14.5, meets the minimum requirements.

-> Go: Checking Package Management
✓ You are using Go Modules (go) for package management.

-> Go: Checking PATH
✓ Your PATH contains /Users/Peter/go/bin.

-> Node: Checking installation
✓ The node executable was found on your system at: /Users/Peter/.nvm/versions/node/v10.16.0/bin/node

-> Node: Checking minimum version requirements
✓ Your version of Node, v10.16.0, meets the minimum requirements.

-> NPM: Checking installation
✓ The npm executable was found on your system at: /Users/Peter/.nvm/versions/node/v10.16.0/bin/npm

-> NPM: Checking minimum version requirements
✓ Your version of NPM, 6.9.0, meets the minimum requirements.

-> Yarn: Checking installation
✓ The yarnpkg executable was found on your system at: /Users/Peter/.nvm/versions/node/v10.16.0/bin/yarnpkg

-> Yarn: Checking minimum version requirements
✓ Your version of Yarn, 1.22.4, meets the minimum requirements.

-> PostgreSQL: Checking installation
✘ The postgres executable could not be found on your system.
For help setting up your Postgres environment please follow the instructions for you platform at:

https://www.postgresql.org/download/

-> MySQL: Checking installation
✘ The mysql executable could not be found on your system.
For help setting up your MySQL environment please follow the instructions for you platform at:

https://www.mysql.com/downloads/

-> SQLite3: Checking installation
✓ The sqlite3 executable was found on your system at: /usr/bin/sqlite3

-> SQLite3: Checking minimum version requirements
✓ Your version of SQLite3, 3.28.0, meets the minimum requirements.

-> Cockroach: Checking installation
✘ The cockroach executable could not be found on your system.
For help setting up your Cockroach environment please follow the instructions for you platform at:

https://www.cockroachlabs.com/docs/stable/

-> Buffalo (CLI): Checking installation
✓ The buffalo executable was found on your system at: /usr/local/bin/buffalo

-> Buffalo (CLI): Checking minimum version requirements
✓ Your version of Buffalo (CLI), v0.16.12, meets the minimum requirements.

-> Buffalo: Application Details
GoPath /Users/Peter/go
WithModules true
Name gateway
Bin bin/gateway
VCS git
WithPop false
WithSQLite false
WithDep false
WithWebpack false
WithNodeJs false
WithYarn false
WithDocker true
WithGrifts true
AsWeb false
AsAPI true
InApp true
PackageJSON {map[]}

-> Buffalo: config/buffalo-app.toml
name = "gateway"
bin = "bin/gateway"
vcs = "git"
with_pop = false
with_sqlite = false
with_dep = false
with_webpack = false
with_nodejs = false
with_yarn = false
with_docker = true
with_grifts = true
as_web = false
as_api = true

-> Buffalo: config/buffalo-plugins.toml

Suggested solution(s)

I'm not able to create a pull request (as I get the error "Permission to gobuffalo/buffalo.git denied" when trying to publish a branch), but I think there are two possible solutions to this issue:

Preferred solution

Modifying the file "genny/resource/templates/standard/action/resource-name.go.tmpl" to change the code below:

// {{$a.String}} default implementation. func (v {{$.opts.Name.Resource}}Resource) {{$a.String}}(c buffalo.Context) error { return c.Render(http.StatusOK, r.String("{{$.opts.Model.Proper}}#{{$a.String}}")) }

And change this to:

// {{$a.Pascalize}} default implementation. func (v {{$.opts.Name.Resource}}Resource) {{$a.Pascalize}}(c buffalo.Context) error { return c.Render(http.StatusOK, r.String("{{$.opts.Model.Proper}}#{{$a.Pascalize}}")) }

Alternative solution

Modifying the file "genny/resource/actions.go" to change the code below:

func actions(opts *Options) []name.Ident { actions := []name.Ident{ name.New("list"), name.New("show"), name.New("create"), name.New("update"), name.New("destroy"), } if opts.App.AsWeb { actions = append(actions, name.New("new"), name.New("edit")) } return actions }

And change this to:

func actions(opts *Options) []name.Ident { actions := []name.Ident{ name.New("List"), name.New("Show"), name.New("Create"), name.New("Update"), name.New("Destroy"), } if opts.App.AsWeb { actions = append(actions, name.New("New"), name.New("Edit")) } return actions }

[paganotoni]

Should be solved in v0.16.14