Skip to content
This repository has been archived by the owner on Feb 24, 2024. It is now read-only.

NODE_ENV not being set to production during build #845

Closed
bastiankoetsier opened this issue Jan 10, 2018 · 1 comment
Closed

NODE_ENV not being set to production during build #845

bastiankoetsier opened this issue Jan 10, 2018 · 1 comment
Assignees
@markbates
Milestone
0.11.0

Comments

@bastiankoetsier
Copy link

With the removal of loading the whole environment-variables before exec, it is prevented that NODE_ENV gets actually set to production during buffalo build .

This prevents the execution of webpack plugins like uglify for a production build.
It can be circumvented by setting NODE_ENV=production buffalo build
@ntakouris
Copy link
Contributor

Probably fixed by #846 (if it gets merged)

@markbates markbates mentioned this issue Jan 11, 2018
Closed
markbates added a commit that referenced this issue Jan 23, 2018
@markbates
NODE_ENV not being set to production during build fixes #845
1170432
@markbates markbates self-assigned this Jan 23, 2018
@markbates markbates added this to the 0.11.0 milestone Jan 23, 2018
markbates added a commit that referenced this issue Jan 24, 2018
@markbates
Merge pull request #873 from gobuffalo/fix-node-env
0c9666a 
NODE_ENV not being set to production during build fixes #845
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@markbates markbates

Labels
None yet
Projects
None yet
Milestone
0.11.0
Development

No branches or pull requests
3 participants
@markbates @ntakouris @bastiankoetsier