This repository has been archived by the owner on Feb 24, 2024. It is now read-only.
split out a few things from the generated action.App() implementation. #1008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hopefully this will help with a bit more in-line documentation, as well, as showing a pattern for keeping that method tame when it starts getting big.
markbates
changed the title
stanislas-m
approved these changes
Apr 5, 2018
stanislas-m
pushed a commit
that referenced
this pull request
May 12, 2018
#1008) * split out a few things from the generated action.App() implementation. Hopefully this will help with a bit more in-line documentation, as well, as showing a pattern for keeping that method tame when it starts getting big. * updated to mention using a proxy * added a little more documentation to the generated main.go
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this will help with a bit more in-line documentation, as well, as showing a pattern for keeping that method tame when it starts getting big.