This repository has been archived by the owner on Feb 24, 2024. It is now read-only.
Adding clean-obsolete-chunks which will clean up on recompile #1013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #1012 cc @markbates |
…uffalo/buffalo into task/moving-to-clean-obsolete-chunks
|
@markbates You ok if I merge this one? I've tested it and is looking good. |
|
@paganotoni sorry it took me so long to get to it. |
|
no worries! thanks! |
markbates
pushed a commit
that referenced
this pull request
Apr 10, 2018
* adding clean-obsolete-chunks which will clean up on recompile * adding dot between css name and hash
stanislas-m
pushed a commit
that referenced
this pull request
May 12, 2018
* adding clean-obsolete-chunks which will clean up on recompile * adding dot between css name and hash
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes our webpack config clean obsolete chunks so instead of just cleaning all the
public/assetsfolder this will remove only obsolete chunks, this will cause 2 great outcomes:Appart from that change I've also:
package.jsonto avoid a warning that was being shown.package.jsonby using dependencies and devDependencies respectively.