-
-
Notifications
You must be signed in to change notification settings - Fork 578
Allow the buffalo binary to use the version vendored with dep #1023
Conversation
@stanislas-m @paganotoni would love to have on this at some point by either one of you. even better, play with it. :) |
@markbates I will play with it tonight, do you have any suggestion on how to test it? |
Just build the buffalo binary from the branch and use as normal. Report anything strange. See the notes about when it kicks in. You’ll know it’s working because it will print vXXX [development] at the top. |
The idea is that it’s virtually seemless. |
@markbates i just run it with my pre-productive app and seems to work 👌, as far as I can tell from the logs (and i'm assuming all this is expected behavior based on the code):
I see both happening correctly if I remove my Gopkg.yml and re-add it. |
@markbates do you think its worth to add some automated tests for this or is it too overkill at this level? (i would love to have some). |
@paganotoni I would love some automated tests around it? any idea how to add them? |
Probably in our Dockerfile, we could at least check the output of a dep project for |
@markbates sorry if I'm overdemanding, I'm very excited about this, just by reading it learned a lot :) |
@paganotoni lol, I appreciate the input actually. want to try and see if you can whip up a little something, even a smoke test in the docker file? |
* adding some filetests to check the buffalo-version output * making it version independent
@paganotoni any idea why the file tests you added for this are failing? |
@markbates not sure, what are your thoughts on printing something that let us know that we're running the version of dep instead of GOPATH version? |
@paganotoni that was why I was printing |
@markbates find it, i'll update the PR soon :) |
* wip * Vendor the Buffalo Binary inside Applications fixes #986 * added some docs for code climate * log packing if in debug mode * fixed weird import * Update vbuffalo.go * fixed issue with gometalinter * adding some filetests to check the buffalo-version output (#1028) * adding some filetests to check the buffalo-version output * making it version independent * removing unneeded newline from broken filetest
If the following conditions then
vbuffalo
will attempt take over:vendor
directory MUST existIf those conditions then
vbuffalo
behaves in a similar fashion togrift
. It will first create a new.grifter/main.go
and use that to build a new binary,bin/vbuffalo
that has been compiled using the vendored version of Buffalo.Another requirement is this section in
Gopkg.toml
For new applications the appropriate toml will be generated. For existing applications we will add the missing
prune
sections to theirGopkg.toml
file if they don't already have them.