This repository has been archived by the owner on Feb 24, 2024. It is now read-only.
updated the integration tests to use gometalinter and setup a bunch of linters that need to pass before a PR can merge. #1025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linters that need to pass before a PR can merge.
paganotoni
reviewed
Apr 13, 2018
There was a problem hiding this comment.
This looks good to me, @markbates are the rest of the changes what we need to pass the metalinter?
|
@paganotoni yeah, it wouldn't be fair of me to impose this without first making sure it ran clean. :) |
stanislas-m
suggested changes
Apr 13, 2018
| err = server.ListenAndServe() | ||
| if err = server.Serve(listener); err != nil { | ||
| return a.Stop(err) | ||
| } |
There was a problem hiding this comment.
There is a missing return nil here, isn't it?
stanislas-m
approved these changes
Apr 13, 2018
stanislas-m
pushed a commit
that referenced
this pull request
May 12, 2018
…f linters that need to pass before a PR can merge. (#1025) * updated the integration tests to use gometalinter and setup a bunch of linters that need to pass before a PR can merge. * added the --deadline flag for gometalinter * lol, apparently that new line was important. oops * removed a deprecated call * added a missing return
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.