This repository has been archived by the owner on Feb 24, 2024. It is now read-only.
Wip mail embed #1041
Merged
Wip mail embed #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbyoconnor
suggested changes
Apr 21, 2018
mail/message.go
Outdated
| @@ -32,6 +33,7 @@ type Attachment struct { | |||
| Name string | |||
| Reader io.Reader | |||
| ContentType string | |||
| Embeded bool | |||
mail/message.go
Outdated
| @@ -72,6 +74,19 @@ func (m *Message) AddAttachment(name, contentType string, r io.Reader) error { | |||
| Name: name, | |||
| ContentType: contentType, | |||
| Reader: r, | |||
| Embeded: false, | |||
mail/message.go
Outdated
| m.Attachments = append(m.Attachments, Attachment{ | ||
| Name: name, | ||
| Reader: r, | ||
| Embeded: true, |
mail/smtp_sender_test.go
Outdated
| @@ -36,6 +36,8 @@ func TestSendPlain(t *testing.T) { | |||
| m.Bcc = []string{"[email protected]"} | |||
|
|
|||
| m.AddAttachment("someFile.txt", "text/plain", bytes.NewBuffer([]byte("hello"))) | |||
| m.AddAttachment("otherFile.txt", "text/plain", bytes.NewBuffer([]byte("bye"))) | |||
| m.AddEmbeded("test.jpg", bytes.NewBuffer([]byte("not a real image"))) | |||
markbates
suggested changes
Apr 22, 2018
There was a problem hiding this comment.
@kteb this looks great. We just need to fix the spelling of Embedded, which is why the tests failed. You can run grift tools:lint in the gobuffalo/buffalo root folder and it will run a bunch of linting tools on your code to make sure it passes stuff like this. :) This will be a nice feature. Thanks!
|
Is something still missing ? |
|
Looks great. Thanks! |
stanislas-m
pushed a commit
that referenced
this pull request
May 12, 2018
* Fixed bug when attaching more thant one file * Add AddEmbeded methods to a message * Spelling fixes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First trial implementation for fixing the following issue: #1040