This repository has been archived by the owner on Feb 24, 2024. It is now read-only.
moves to use bootstrap 4.1.1 to avoid a text-hide warning #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fixed templateRenderer to work with plush 4.5.7 * added a test * fixed appveyor to run tests
|
@stanislas-m do you by chance know what should I do in appveyor to make it pass? |
|
@paganotoni #1050 will fix the problem. :) |
…when compiling css
stanislas-m
force-pushed
the
task/bootstrap-warning
branch
from
f2a25d3 to
addc9a1
Compare
stanislas-m
approved these changes
May 8, 2018
stanislas-m
pushed a commit
that referenced
this pull request
May 12, 2018
* fixed templateRenderer to work with plush 4.5.7 (#1049) * fixed templateRenderer to work with plush 4.5.7 * added a test * fixed appveyor to run tests * version bump * Updated SHOULDERS.md * moves to use bootstrap 4.1.1 to avoid a text-hide warning that shows when compiling css
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest bootstrap releases removes a warning when compiling with the text-hide mixin, I've seen that warning in our development version since we move to use bootstrap 4.1.0 as default.
This PR moves buffalo to use 4.1.1 instead of 4.1.0.