This repository has been archived by the owner on Feb 24, 2024. It is now read-only.
Allowing to skip schema load #1094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markbates
suggested changes
Jun 9, 2018
buffalo/cmd/test.go
Outdated
|
|
||
| func init() { | ||
| decorate("test", testCmd) | ||
| testCmd.Flags().BoolVarP(&buildOptions.ExtractAssets, "skip-schema-load", "s", false, "skips loading the schema and instead runs migrations before running tests") |
There was a problem hiding this comment.
I'm not a fan of the name of this flag. Any other options?
There was a problem hiding this comment.
Oh boy! ouch! going for it.
There was a problem hiding this comment.
@markbates what about "forceMigrations" and -m --force-migrations ?
|
@markbates moved the variable to be |
markbates
approved these changes
Jun 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some situations, the database user configured in the database connection is not the owner of the plpgsql extension, and Postgres ends up saying when we try to load the schema file.
This PR allows to skip schema load and go straight to migrations.