This repository has been archived by the owner on Feb 24, 2024. It is now read-only.
Fixes panicking built binaries #1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
is was possible for this to result in database drivers loading twice and the app panicing.
markbates
changed the title
marstr
approved these changes
Jun 21, 2018
paganotoni
approved these changes
Jun 21, 2018
Codecov Report
@@ Coverage Diff @@
## master #1125 +/- ##
==========================================
+ Coverage 60.76% 61.07% +0.31%
==========================================
Files 56 56
Lines 2867 2867
==========================================
+ Hits 1742 1751 +9
+ Misses 1022 1014 -8
+ Partials 103 102 -1
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of the way we were making built binaries act as Buffalo binaries is was possible for this to result in database drivers loading twice and the app panicing.
NOTE This is against
masteron purpose! This will be the only thing released asv0.12.1. That milestone will move tov0.12.2.