This repository has been archived by the owner on Feb 24, 2024. It is now read-only.
make sure all caught panics have a stack with them #1176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marwan-at-work
suggested changes
Jul 16, 2018
| @@ -58,12 +58,12 @@ func (a *App) PanicHandler(next Handler) Handler { | |||
| if r != nil { //catch | |||
| switch t := r.(type) { | |||
| case error: | |||
There was a problem hiding this comment.
you might have to do err = t otherwise err is nill still
Codecov Report
@@ Coverage Diff @@
## development #1176 +/- ##
===========================================
Coverage 51.1% 51.1%
===========================================
Files 76 76
Lines 3835 3835
===========================================
Hits 1960 1960
Misses 1757 1757
Partials 118 118
Continue to review full report at Codecov.
|
|
@marwan-at-work fixed! and added some tests to make sure. thanks for the review! |
marwan-at-work
previously approved these changes
Jul 16, 2018
There was a problem hiding this comment.
@markbates thanks. This definitely takes care of the nil error. However, Buffalo still doesn't print the stack in the log. This is probably related to #1171
fyi this is what i got
ERRO[2018-07-16T12:43:20-04:00] runtime error: invalid memory address or nil pointer dereference content_type="*/*" duration="495.828µs" human_size="0 B" method=GET params="{}" path=/hem request_id="4b361f3b89-f0c6aa9aff" size="0" status="0"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.