This repository has been archived by the owner on Feb 24, 2024. It is now read-only.
Filtered param logger #1204
Merged
Filtered param logger #1204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #1204 +/- ##
===============================================
+ Coverage 53.21% 53.62% +0.41%
===============================================
Files 75 75
Lines 3798 3834 +36
===============================================
+ Hits 2021 2056 +35
+ Misses 1659 1655 -4
- Partials 118 123 +5
Continue to review full report at Codecov.
|
mclark4386
previously approved these changes
Aug 2, 2018
|
@mclark4386 can you recheck it ? need your approval again :) |
mclark4386
approved these changes
Aug 2, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the param logger consider a blacklist for parameters content and replace these with [FILTERED].