This repository has been archived by the owner on Feb 24, 2024. It is now read-only.
Using ParameterExclusionList instead of ParameterFilterBlackList #1208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #1208 +/- ##
============================================
Coverage 53.82% 53.82%
============================================
Files 75 75
Lines 3859 3859
============================================
Hits 2077 2077
Misses 1657 1657
Partials 125 125
Continue to review full report at Codecov.
|
markbates
suggested changes
Aug 3, 2018
middleware/param_logger.go
Outdated
| @@ -30,7 +30,7 @@ type parameterLogger struct { | |||
| // ParameterLogger logs form and parameter values to the loggers | |||
| func ParameterLogger(next buffalo.Handler) buffalo.Handler { | |||
| pl := parameterLogger{ | |||
| blacklist: ParameterFilterBlackList, | |||
| blacklist: ParameterExclusionList, | |||
middleware/param_logger.go
Outdated
| //request, and returns a copy of the request parameters replacing blacklisted params | ||
| //with [FILTERED]. | ||
| func (pl parameterLogger) maskSecrets(form url.Values) url.Values { | ||
| if len(pl.blacklist) == 0 { | ||
| pl.blacklist = ParameterFilterBlackList | ||
| pl.blacklist = ParameterExclusionList |
|
@paganotoni there are still a few references to |
|
@markbates i think is covered now, please take a look and let me know if i missed something. |
markbates
approved these changes
Aug 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc: @markbates