Skip to content
This repository has been archived by the owner on Feb 24, 2024. It is now read-only.

Updated BACKERS.md #1210

Merged
merged 1 commit into from
Aug 3, 2018
Merged

Updated BACKERS.md #1210

merged 1 commit into from
Aug 3, 2018

Conversation

stanislas-m
Copy link
Member

Fixed #1209 to merge to master:

@landonbjones: Added Zhorty because of my Generous Backer status on https://www.patreon.com/buffalo.

Added Zhorty because of my Generous Backer status on https://www.patreon.com/buffalo.
@stanislas-m stanislas-m requested a review from markbates August 3, 2018 16:32
@codecov
Copy link

codecov bot commented Aug 3, 2018

Codecov Report

Merging #1210 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1210   +/-   ##
=======================================
  Coverage   60.79%   60.79%           
=======================================
  Files          58       58           
  Lines        2959     2959           
=======================================
  Hits         1799     1799           
  Misses       1046     1046           
  Partials      114      114

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a98d8d4...d646a70. Read the comment docs.

@markbates
Copy link
Member

Thanks Stan!

@markbates markbates merged commit 9935af1 into master Aug 3, 2018
markbates pushed a commit that referenced this pull request Aug 6, 2018
* Updated BACKERS.md (#1210)

Added Zhorty because of my Generous Backer status on https://www.patreon.com/buffalo.

* buffalo/cmd: make len comparison more clear

len call never returns negative values, so checking against 0 is enough.

Found using https://go-critic.github.io/overview#sloppyLen-ref
markbates pushed a commit that referenced this pull request Aug 6, 2018
* Updated BACKERS.md (#1210)

Added Zhorty because of my Generous Backer status on https://www.patreon.com/buffalo.

* internal/release,render: remove redundant func wrapping

Remove function wrappers that match enclosed function
signature in 1-to-1 fashion. Just use function value directly.

Found using https://go-critic.github.io/overview#unlambda-ref
@stanislas-m stanislas-m deleted the landonbjones-patch-1 branch August 6, 2018 17:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants