This repository has been archived by the owner on Feb 24, 2024. It is now read-only.
Respect GO_ENV when setting NODE_ENV #1266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, it's not really possible to set NODE_ENV (that is/might be used in webpack) to anything else than development or production. I believe it should be. That code works for me in my project, so I can use it for my "test" environment as well ;)
stanislas-m
approved these changes
Aug 29, 2018
markbates
approved these changes
Sep 3, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, it's not really possible to set NODE_ENV (that is/might be used in webpack) to anything else than development or production. I believe it should be. That code works for me in my project, so I can use it for my "test" environment as well ;)