This repository has been archived by the owner on Feb 24, 2024. It is now read-only.
Appveyor Fixes #1274
Merged
Appveyor Fixes #1274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanislas-m
reviewed
Sep 1, 2018
appveyor.yml
Outdated
|
|
||
| test_script: | ||
| - cmd: for /f "" %%G in ('go list github.com/gobuffalo/buffalo/... ^| find /i /v "/vendor/"') do ( go test -tags "sqlite integration_test" %%G & IF ERRORLEVEL == 1 EXIT 1) | ||
| - set GO111MODULE=on | ||
| - go test -race ./... |
There was a problem hiding this comment.
Can we keep the integration tests? That's one of the reasons we have a specific build for Windows.
|
Yes! Sorry I missed that.
…On Sep 1, 2018, 11:46 AM -0400, Stanislas Michalak ***@***.***>, wrote:
@stanislas-m commented on this pull request.
In appveyor.yml:
>
test_script:
-- cmd: for /f "" %%G in ('go list github.com/gobuffalo/buffalo/... ^| find /i /v "/vendor/"') do ( go test -tags "sqlite integration_test" %%G & IF ERRORLEVEL == 1 EXIT 1)
+ - set GO111MODULE=on
+ - go test -race ./...
Can we keep the integration tests? That's one of the reasons we have a specific build for Windows.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Codecov Report
@@ Coverage Diff @@
## development #1274 +/- ##
===============================================
+ Coverage 53.82% 53.83% +0.01%
===============================================
Files 75 75
Lines 3454 3453 -1
===============================================
Hits 1859 1859
+ Misses 1494 1493 -1
Partials 101 101
Continue to review full report at Codecov.
|
|
@stanislas-m added the integration tests back. sorry about that. :) |
|
@markbates Np. :) |
stanislas-m
approved these changes
Sep 1, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.