Skip to content
This repository has been archived by the owner on Feb 24, 2024. It is now read-only.

does a better job of rebranding refresh: events as buffalo:dev: events #1321

Merged
merged 2 commits into from
Sep 24, 2018
Merged

does a better job of rebranding refresh: events as buffalo:dev: events #1321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
afea4da
does a better job of rebranding refresh: events as buffalo:dev: events
markbates Sep 24, 2018
c19ea35
updated events
markbates Sep 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion buffalo/cmd/dev.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import (
func init() {
events.NamedListen("buffalo:dev", func(e events.Event) {
if strings.HasPrefix(e.Kind, "refresh:") {
e.Kind = "buffalo:" + e.Kind
e.Kind = strings.Replace(e.Kind, "refresh:", "buffalo:dev:", 1)
events.Emit(e)
}
})
Expand Down
2 changes: 1 addition & 1 deletion errors.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ func (a *App) defaultErrorMiddleware(next Handler) Handler {
err = eh(status, err, c)
if err != nil {
events.Emit(events.Event{
Kind: events.ErrGeneral,
Kind: EvtFailureErr,
Message: "unable to handle error and giving up",
Error: err,
Payload: payload,
Expand Down
3 changes: 3 additions & 0 deletions events.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,7 @@ const (
EvtWorkerStop = "buffalo:worker:stop"
// EvtWorkerStopErr is emitted when an error occurs when stopping workers
EvtWorkerStopErr = "buffalo:worker:stop:err"

// EvtFailureErr is emitted when something can't be processed at all. it is a bad thing
EvtFailureErr = "buffalo:failure:err"
)
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ require (
github.com/gobuffalo/buffalo-plugins v0.0.0-20180924041210-6ea00eeaef92
github.com/gobuffalo/buffalo-pop v0.0.0-20180924015429-afa730c68d32
github.com/gobuffalo/envy v1.6.4
github.com/gobuffalo/events v1.0.1
github.com/gobuffalo/events v1.0.2
github.com/gobuffalo/github_flavored_markdown v1.0.5
github.com/gobuffalo/httptest v1.0.1
github.com/gobuffalo/makr v1.1.5
Expand Down
7 changes: 4 additions & 3 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ github.com/gobuffalo/envy v1.6.4/go.mod h1:Abh+Jfw475/NWtYMEt+hnJWRiC8INKWibIMyN
github.com/gobuffalo/events v0.0.0-20180919212028-867dc2348bad/go.mod h1:llrZYJ6ap/G7OwAEIbGJzyKlzWJy/F84lPgilFIBpH4=
github.com/gobuffalo/events v0.0.0-20180922214205-bcd0f5dd556a/go.mod h1:1y8L9VCEC17GFRd98juWpWqIX7WXvDDJ3W1qNy02iHg=
github.com/gobuffalo/events v0.0.0-20180924042527-b0372953254d/go.mod h1:rSHVdTfkpJgtv4ZaMihvdxA/3dw6Rzfse75/ewrm08M=
github.com/gobuffalo/events v1.0.1 h1:jhOOv/8aqrn1+ly1VBZVzFdPcVDFhvDkqtnVhqn8XRU=
github.com/gobuffalo/events v1.0.1/go.mod h1:Ida1WGS/W4d/BALR72iieJ8LQGKaUHISgUPcBIpYeTM=
github.com/gobuffalo/events v1.0.2 h1:9sokzhPipEL6mN+KHxs6dNSE+WcPa+vNZSC9qTGnBbc=
github.com/gobuffalo/events v1.0.2/go.mod h1:i+LaFjejdNAXYYy/wjTf9FD/9I2cnxI+38YxBaSsNX0=
github.com/gobuffalo/fizz v1.0.7/go.mod h1:fbtmvB0dcsGJUxM/S8biqkQtvykqPQGdkcg94zVu8GA=
github.com/gobuffalo/fizz v1.0.10 h1:MspJcEEBN2eApqiFd4tuoTpYZF6wM5B6/Ink/rJcqOI=
github.com/gobuffalo/fizz v1.0.10/go.mod h1:jpD+pJ065MDYCc4nA86aUQ/ovwCjGGNl4zq4xrAxJa0=
Expand Down Expand Up @@ -283,8 +283,9 @@ golang.org/x/sys v0.0.0-20180906133057-8cf3aee42992/go.mod h1:STP8DvDyc/dI5b8T5h
golang.org/x/sys v0.0.0-20180909124046-d0be0721c37e/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY=
golang.org/x/sys v0.0.0-20180918153733-ee1b12c67af4/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY=
golang.org/x/sys v0.0.0-20180920110915-d641721ec2de/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY=
golang.org/x/sys v0.0.0-20180921163948-d47a0f339242 h1:5DYsa+ZAwcJHjuY0Qet390sUr7qwkpnRsUNjddyc0b8=
golang.org/x/sys v0.0.0-20180921163948-d47a0f339242/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY=
golang.org/x/sys v0.0.0-20180924142050-c01370cb5c9b h1:IttiFPmVSU0Fu6o5f05qydRhwn3mF7V4K9Ft+gHeC08=
golang.org/x/sys v0.0.0-20180924142050-c01370cb5c9b/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY=
golang.org/x/text v0.3.0 h1:g61tztE5qeGQ89tm6NTjjM9VPIm088od1l6aSorWRWg=
golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ=
golang.org/x/tools v0.0.0-20180904205237-0aa4b8830f48/go.mod h1:n7NCudcB/nEzxVGmLbDWY5pfWTLqBcC2KZ6jyYvM4mQ=
Expand Down