Skip to content
This repository has been archived by the owner on Feb 24, 2024. It is now read-only.

[WIP] access routes from email #1324

Closed
wants to merge 2 commits into from
Closed

Conversation

kteb
Copy link
Member

@kteb kteb commented Sep 26, 2018

First try of #1296

I tried quickly the code and it seems working, but I love a review on this one.

And advice where to add the the tests (maybe in default_context_test.go ?

The changes in the mailer are breaking changes, so I think adaption in buffalo fix is needed (it will not stop working, but will not give this functionality to the people who used the old generator).

Tests are not yet incuded
@kteb kteb requested a review from a team September 26, 2018 06:08
@kteb kteb changed the base branch from master to development September 26, 2018 06:09
@codecov
Copy link

codecov bot commented Sep 26, 2018

Codecov Report

Merging #1324 into development will increase coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff               @@
##           development    #1324     +/-   ##
==============================================
+ Coverage        48.23%   48.33%   +0.1%     
==============================================
  Files               90       90             
  Lines             3987     3995      +8     
==============================================
+ Hits              1923     1931      +8     
  Misses            1962     1962             
  Partials           102      102
Impacted Files Coverage Δ
context.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e56fdc3...c1ac9c0. Read the comment docs.

@kteb
Copy link
Member Author

kteb commented Oct 1, 2018

Better implementation on #1338

@kteb kteb closed this Oct 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant