Skip to content
This repository has been archived by the owner on Feb 24, 2024. It is now read-only.

build (buffalo build) failing fixes #1323 #1331

Merged
merged 8 commits into from
Sep 30, 2018
Merged

build (buffalo build) failing fixes #1323 #1331

merged 8 commits into from
Sep 30, 2018

Conversation

markbates
Copy link
Member

@markbates markbates commented Sep 27, 2018

This ensures that build time packages are installed by either running go get or dep ensure right before the binary is built in buffalo build.

@markbates markbates requested a review from a team September 27, 2018 13:46
@markbates markbates added this to the v0.13.0 milestone Sep 27, 2018
@codecov
Copy link

codecov bot commented Sep 27, 2018

Codecov Report

Merging #1331 into development will decrease coverage by 0.13%.
The diff coverage is 0%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #1331      +/-   ##
===============================================
- Coverage        48.28%   48.15%   -0.14%     
===============================================
  Files               90       91       +1     
  Lines             3991     4002      +11     
===============================================
  Hits              1927     1927              
- Misses            1962     1973      +11     
  Partials           102      102
Impacted Files Coverage Δ
buffalo/cmd/build/deps.go 0% <0%> (ø)
buffalo/cmd/build/builder.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 426c84d...ac17485. Read the comment docs.

@markbates markbates merged commit 137b670 into development Sep 30, 2018
@markbates markbates deleted the fixes-1323 branch September 30, 2018 14:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant