Skip to content
This repository has been archived by the owner on Feb 24, 2024. It is now read-only.

Array already has time.RFC3339 const #1345

Merged
merged 4 commits into from
Oct 10, 2018
Merged

Array already has time.RFC3339 const #1345

merged 4 commits into from
Oct 10, 2018

Conversation

tamadamas
Copy link
Contributor

@tamadamas tamadamas commented Oct 1, 2018 •
edited
Loading

I found that raw date at timeFormats is exactly the time.RFC3339, so we can remove duplicate one

@markbates markbates requested a review from a team October 1, 2018 20:58
markbates
markbates suggested changes Oct 3, 2018
View reviewed changes
Copy link
Member

@markbates markbates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with removing the duplicate, but can we keep one of them in the first position? Thanks.

@tamadamas
Copy link
Contributor Author

@markbates I've updated

@markbates markbates added this to the v0.13.0 milestone Oct 8, 2018
@markbates
Copy link
Member

Thanks!

@markbates markbates merged commit cea9617 into gobuffalo:development Oct 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@markbates markbates markbates approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.13.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tamadamas @markbates