-
-
Notifications
You must be signed in to change notification settings - Fork 579
Add --skip-build-deps option for build #1672
Add --skip-build-deps option for build #1672
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was waiting for someone to add this! Thanks!
Looks like the tests are failing, would you mind taking at look? Thanks. |
Yes, will do asap.
:) it is good thing that others can use it too. Clad to help. |
Okay, so there is actually two bugs in master now that prevents this pull requests pipelines to pass. Another one is -<form action="/users/user-id" id="user-form" method="POST"><div class="form-group"><label>Name</label><input class=" form-control" id="user-Name" name="Name" type="text" value="Mark" /></div></form>
+<form id="user-form" method="POST"><div class="form-group"><label>Name</label><input class=" form-control" id="user-Name" name="Name" type="text" value="Mark" /></div></form> Another case is that there is this go module support bug which makes tests say:
So the question is that is someone already on those issues since they do happen on other branches too.. I do not have more time for this weekend so, for me this stalls here unfortunately. |
@markbates Yes, I inspected the PL through and it shows well who developed Buffalo and who started learning Go and Go Buffalo few weeks ago :D. Looks like that would solve issues. I will merge master here when it is ready. And on side note, we have in Liana Technologies done now few pull requests with good response and changes has gone through quickly. So, I'd like to thank whole Core Team for that! |
All passing now! Thanks again! |
When using vendored go modules, one may want to leave out
go get
part frombuffalo build
for various reasons.My reason to leave module update out is that we have dependencies in private repositories that cannot(or is hard enough to) be fetched while building testing environment for larger set of applications within Docker container.
Other reasons: