Skip to content
This repository has been archived by the owner on Feb 24, 2024. It is now read-only.

Add --skip-build-deps option for build #1672

Merged
merged 5 commits into from
May 26, 2019

Conversation

jani123
Copy link
Contributor

@jani123 jani123 commented May 24, 2019

When using vendored go modules, one may want to leave out go get part from buffalo build for various reasons.

My reason to leave module update out is that we have dependencies in private repositories that cannot(or is hard enough to) be fetched while building testing environment for larger set of applications within Docker container.

Other reasons:

  • Network connection is down
  • You are developing behind expensive mobile network
  • There is broken server at GitHub and cannot access repository(has happened 3 times with npm modules for me.. yes, it is unbelievable)
  • Dependencies can be saved somewhere and they are saved if they are removed from internet(known to happen) => build still works even though one cannot actually fetch dependencies
  • I'm sure there is many other reasons too.

@jani123 jani123 requested a review from a team as a code owner May 24, 2019 18:40
markbates
markbates previously approved these changes May 24, 2019
Copy link
Member

@markbates markbates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was waiting for someone to add this! Thanks!

@markbates
Copy link
Member

Looks like the tests are failing, would you mind taking at look? Thanks.

@ghost
Copy link

ghost commented May 25, 2019

Looks like the tests are failing, would you mind taking at look? Thanks.

Yes, will do asap.

I was waiting for someone to add this! Thanks!

:) it is good thing that others can use it too. Clad to help.

@jani123
Copy link
Contributor Author

jani123 commented May 25, 2019

Okay, so there is actually two bugs in master now that prevents this pull requests pipelines to pass.

Another one is Test_Template_Partial_Form test which fails because it uses anonymous struct without ID field. I committed fix for this, but pipelines now finds some different version of some project and form doesn't actually contain action tag as it does on my environment:

-<form action="/users/user-id" id="user-form" method="POST"><div class="form-group"><label>Name</label><input class=" form-control" id="user-Name" name="Name" type="text" value="Mark" /></div></form>
+<form id="user-form" method="POST"><div class="form-group"><label>Name</label><input class=" form-control" id="user-Name" name="Name" type="text" value="Mark" /></div></form>

Another case is that there is this go module support bug which makes tests say:

go: unknown subcommand "mod"

So the question is that is someone already on those issues since they do happen on other branches too.. I do not have more time for this weekend so, for me this stalls here unfortunately.

@markbates
Copy link
Member

@jani123 I think this PR should fix the underlying test issues. #1673 would love a review if you have a minute.

@markbates markbates added this to the Next milestone May 25, 2019
@ghost
Copy link

ghost commented May 26, 2019

@markbates Yes, I inspected the PL through and it shows well who developed Buffalo and who started learning Go and Go Buffalo few weeks ago :D. Looks like that would solve issues. I will merge master here when it is ready.

And on side note, we have in Liana Technologies done now few pull requests with good response and changes has gone through quickly. So, I'd like to thank whole Core Team for that!

@markbates
Copy link
Member

All passing now! Thanks again!

@markbates markbates changed the base branch from master to development May 26, 2019 17:05
@markbates markbates merged commit 6c8bca6 into gobuffalo:development May 26, 2019
@jani123 jani123 deleted the add-skip-build-deps-to-build branch May 27, 2019 04:43
@markbates markbates modified the milestones: Next, v0.14.5 Jun 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants