Skip to content
This repository has been archived by the owner on Feb 24, 2024. It is now read-only.

pulls in the buffalo-docker plugin #1709

Merged
merged 3 commits into from
Jun 23, 2019
Merged

pulls in the buffalo-docker plugin #1709

merged 3 commits into from
Jun 23, 2019

Conversation

markbates
Copy link
Member

No description provided.

@markbates markbates requested a review from a team as a code owner June 22, 2019 22:33
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some fixes!

P.S. share your ideas, feedbacks or issues with us at https://github.com/fixmie/feedback (this message will be removed after the beta stage).

"github.com/gobuffalo/packr/v2"
)

func New(opts *Options) (*genny.Generator, error) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exported identifier "New" should have comment

Suggested change
func New(opts *Options) (*genny.Generator, error) {
// New ...
func New(opts *Options) (*genny.Generator, error) {

"github.com/gobuffalo/meta"
)

type Options struct {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exported identifier "Options" should have comment

Suggested change
type Options struct {
// Options ...
type Options struct {

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some fixes!

P.S. share your ideas, feedbacks or issues with us at https://github.com/fixmie/feedback (this message will be removed after the beta stage).


// LoadOrStore will return an existing key or
// store the value if not already in the map
func (m *stringMap) LoadOrStore(key string, value string) (string, bool) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two or more consecutive named function parameters share a type, you can omit the type from all but the last

Suggested change
func (m *stringMap) LoadOrStore(key string, value string) (string, bool) {
func (m *stringMap) LoadOrStore(key, value string) (string, bool) {

}

// Store a string in the map
func (m *stringMap) Store(key string, value string) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two or more consecutive named function parameters share a type, you can omit the type from all but the last

Suggested change
func (m *stringMap) Store(key string, value string) {
func (m *stringMap) Store(key, value string) {

@markbates markbates added this to the Next milestone Jun 23, 2019
@markbates markbates merged commit 6d6fdb9 into development Jun 23, 2019
@markbates markbates deleted the pullin-docker branch June 23, 2019 02:20
@markbates markbates modified the milestones: Next, v0.14.7 Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant