-
-
Notifications
You must be signed in to change notification settings - Fork 578
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found some fixes!
P.S. share your ideas, feedbacks or issues with us at https://github.com/fixmie/feedback (this message will be removed after the beta stage).
"github.com/gobuffalo/packr/v2" | ||
) | ||
|
||
func New(opts *Options) (*genny.Generator, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exported identifier "New" should have comment
func New(opts *Options) (*genny.Generator, error) { | |
// New ... | |
func New(opts *Options) (*genny.Generator, error) { |
"github.com/gobuffalo/meta" | ||
) | ||
|
||
type Options struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exported identifier "Options" should have comment
type Options struct { | |
// Options ... | |
type Options struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found some fixes!
P.S. share your ideas, feedbacks or issues with us at https://github.com/fixmie/feedback (this message will be removed after the beta stage).
|
||
// LoadOrStore will return an existing key or | ||
// store the value if not already in the map | ||
func (m *stringMap) LoadOrStore(key string, value string) (string, bool) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two or more consecutive named function parameters share a type, you can omit the type from all but the last
func (m *stringMap) LoadOrStore(key string, value string) (string, bool) { | |
func (m *stringMap) LoadOrStore(key, value string) (string, bool) { |
} | ||
|
||
// Store a string in the map | ||
func (m *stringMap) Store(key string, value string) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two or more consecutive named function parameters share a type, you can omit the type from all but the last
func (m *stringMap) Store(key string, value string) { | |
func (m *stringMap) Store(key, value string) { |
No description provided.