This repository has been archived by the owner on Feb 24, 2024. It is now read-only.
Replace hard-coded webpack with node script call #1718
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the hardcoded webpack commands (dev & build) with standard package.json scripts which can be called with either npm or yarn.
The new applications will be generated with the following new section in the package.json:
Buffalo will then call
yarn run build
(ornpm run build
) when you callbuffalo build
; and it will callyarn run dev
(ornpm run dev
) when you callbuffalo dev
. This allows you to customize the scripts buffalo calls on these steps, providing custom args to the webpack command or even running your own toolchain instead.Thanks to #1729, we'll preserve compatibility with current apps which didn't migrate by hand or run
buffalo fix
: if thebuild
ordev
scripts can't be found, we'll fallback on the old behavior running the hardcoded webpack commands.Migration
The
buffalo fix
command rewrites the package.json file if necessary, adding this newscripts
section if it doesn't already exist.Fixes #1116.