This repository has been archived by the owner on Feb 24, 2024. It is now read-only.
Use model#isPlural to pick which template to auto-render #1728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows using dashes instead of underscores in resource urls.
|
Can you please add some tests? Thanks. Also, Go convention is underscores for file names, which is why Buffalo uses underscores. |
|
Happy to add tests, will do that this evening. I understand the underscore convention for identifiers and file names (this PR doesn't change that), but that convention gets messy when it runs into the more visible url conventions which have their own style guides, especially when it comes to search engines, etc. |
markbates
approved these changes
Jul 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into an issue attempting to use hyphens instead of underscores in resource URLS (Google recommends underscores not be used: https://support.google.com/webmasters/answer/76329?hl=en).
I traced the limitation down to the autorender, which makes assumptions about the url path segment matching the underscore form. Instead, it is possible to know whether to render the index.html or show.html based on whether we have a collection or a single instance of the model.