Skip to content
This repository has been archived by the owner on Feb 24, 2024. It is now read-only.

Switch to more idiomatic Sass usage #1751

Merged
merged 3 commits into from
Aug 7, 2019
Merged

Switch to more idiomatic Sass usage #1751

merged 3 commits into from
Aug 7, 2019

Conversation

lucperkins
Copy link
Contributor

@lucperkins lucperkins commented Aug 1, 2019

Right now, the Buffalo static assets commit what I take to be three no-nos:

  • The Sass is kept in a css folder, which is somewhat misleading
  • The application.scss file doesn't actually use Sass; it's essentially just CSS
  • The Sass templates use tabs

These things are no huge deal, but I think that the changes I'm proposing here provide a more idiomatic usage of Sass and enhance the impression that Sass is a first-class citizen in the pipeline.

@lucperkins lucperkins requested a review from a team as a code owner August 1, 2019 20:04
@markbates
Copy link
Member

Thanks. Can you please open this PR against development?

Also, changing the folder from css to scss is a breaking change, the rest of the PR looks great, except for that and the wrong branch.

Can you pull the folder changes?

Thanks.

@lucperkins lucperkins changed the base branch from master to development August 1, 2019 21:36
@lucperkins
Copy link
Contributor Author

@markbates Okay, I reverted that. In a future release, I would recommend instituting that change but it's no biggie.

@stanislas-m stanislas-m merged commit 7d9c0c5 into gobuffalo:development Aug 7, 2019
@markbates markbates modified the milestones: Next, v0.15.0 Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants