This repository has been archived by the owner on Feb 24, 2024. It is now read-only.
Magic Numbers => HTTP Status Codes #1802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanislas-m
suggested changes
Oct 13, 2019
There was a problem hiding this comment.
Hi @laynemcnish, thanks for this PR!
It seems the tests are failing because you changed some templates without running packr2, so the tests still use the old version. Can you install packr2 (https://github.com/gobuffalo/packr/tree/master/v2) if you haven't already, run it, then push the updated packr2 boxes?
Thanks!
|
@stanislas-m I ran packr2, committed the changes and |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Long time listener, first time caller.
I noticed when generating a new Buffalo project that it was using magic numbers (200, 422, 500, etc) instead of using the default status codes from "net/http". I went ahead and replaced all of the magic numbers with their corresponding status codes and all the tests are passing.
I also snuck in a typo fix for your README. I can see the irony of fixing that particular sentence while also ignoring its advice and not opening an issue first.
Let me know if you'd like any other information or have any changes you'd like to see and I'd be happy to respond.
Thanks!