This repository has been archived by the owner on Feb 24, 2024. It is now read-only.
Improve performance of WrapBuffaloHandler #2146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fasmat
changed the title
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
Any chance this will get merged? |
|
I simplified the code by merging the functionality of the wrappedContext (only used in wrapped handlers) into the default context. |
stanislas-m
approved these changes
Nov 16, 2021
|
Thanks @fasmat and @stanislas-m ! |
fasmat
deleted the
feature/performance-improvements-wrapbuffalohandler
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds performance improvements to the WrapBuffaloHandler function.
In one of my apps I noticed that WrapBuffaloHandler is very slow for what it is trying to do. The reason is that every time the wrapped handler is called a new instance of a buffalo.App is created which is very slow and unnecessary.
This PR should fix the problem. The first commit only contains a benchmark and the commit(s) after that the changes, to be able to see the differences. On my machine I was able to achieve a ~ 40x performance increase with this change.
I also extended the documentation of the relevant function to inform the user that the functionality comes with some drawbacks.